Improve caching #1375
Merged
Improve caching #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Member
Author
|
/review |
rumpl
approved these changes
Jan 16, 2026
simonferquel
requested changes
Jan 16, 2026
Contributor
simonferquel
left a comment
simonferquel
left a comment
There was a problem hiding this comment.
One small changes to make things a tiny bit more robust
| } | ||
| } | ||
|
|
||
| // Cache control checkpoint #1 out of 4 |
Contributor
There was a problem hiding this comment.
This is a bit brittle to only rely on where you add messages in the « system slices » compared to that line of code to make it part of what we think is invariant or not. It is a bit too easy to break the cache.
Can we separate the messages into different slices (invariant messages, lowFrequencyChangeMessages, …) and put the checkpoint when we merge them (in correct order) in the system messages slice?
Member
Author
There was a problem hiding this comment.
@simonferquel Can we merge this and you prepare another PR?
simonferquel
approved these changes
Jan 16, 2026
Contributor
simonferquel
left a comment
simonferquel
left a comment
There was a problem hiding this comment.
Unblocking, fixing in followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few tests and e2e on the way.